store/tikv: remove use of fastrand #22543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: disksing <i@disksing.com>
andylokandy
approved these changes
Jan 27, 2021
AndreMouche
reviewed
Jan 27, 2021
AndreMouche
reviewed
Jan 27, 2021
| @@ -213,7 +212,7 @@ func newTikvStore(uuid string, pdClient pd.Client, spkv SafePointKV, client Clie | |||
| safePoint: 0, | |||
| spTime: time.Now(), | |||
| closed: make(chan struct{}), | |||
| replicaReadSeed: fastrand.Uint32(), | |||
| replicaReadSeed: rand.Uint32(), | |||
There was a problem hiding this comment.
Would it affect the performance?
There was a problem hiding this comment.
forget it, it is not used so frequently
AndreMouche
approved these changes
Jan 27, 2021
ti-srebot
approved these changes
Jan 27, 2021
|
/merge |
ti-srebot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@disksing merge failed. |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@disksing merge failed. |
|
/merge |
3 similar comments
|
/merge |
|
/merge |
|
/merge |
|
/run-all-tests |
|
@disksing merge failed. |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: disksing i@disksing.com
What problem does this PR solve?
Resolve dependency on
fastrand.Part of #22513
What is changed and how it works?
What's Changed:
Use
math/randinstead.Check List
Tests
Release note